<html>
<head><meta charset="utf-8"><title>review meeting 2019-09-06 · t-compiler/wg-parallel-rustc · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/index.html">t-compiler/wg-parallel-rustc</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html">review meeting 2019-09-06</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="175021107"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175021107" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Turon <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175021107">(Sep 05 2019 at 22:35)</a>:</h4>
<p>Hi folks! <span class="user-mention" data-user-id="116009">@nikomatsakis</span> and I are planning to do a pass over the shared-state laid out in <a href="https://github.com/rust-lang/rust/issues/63643" target="_blank" title="https://github.com/rust-lang/rust/issues/63643">the PR audit</a>. We plan to take a breadth-first approach, attempting to put each piece of shared state into a bucket:</p>
<ul>
<li>Necessary state; needs auditing for invariants, atomicity and lock order, and documentation</li>
<li>Unnecessary state; should be refactored away</li>
</ul>
<p>In each case there are subcategories (e.g., in several places fine-grained locks around individual fields were introduced, with unclear atomicity ramifications; in many cases these could be consolidated into a single, more coarse-grained lock).</p>
<p>The goal of the meeting is to categorize as much of the state as we can, and hopefully get to a point where we can write up more detailed issues for what we want to do in most cases. Afterward, we can figure out how to divide up the next steps.</p>
<p>The meeting will be held on Zoom and recorded. The event link is <a href="https://calendar.google.com/event?action=TEMPLATE&amp;tmeid=NGIzOGVraXRxN2pndXY4aGxvZTM5anVkOWUgNnU1cnJ0Y2U2bHJ0djA3cGZpM2RhbWdqdXNAZw&amp;tmsrc=6u5rrtce6lrtv07pfi3damgjus%40group.calendar.google.com" target="_blank" title="https://calendar.google.com/event?action=TEMPLATE&amp;tmeid=NGIzOGVraXRxN2pndXY4aGxvZTM5anVkOWUgNnU1cnJ0Y2U2bHJ0djA3cGZpM2RhbWdqdXNAZw&amp;tmsrc=6u5rrtce6lrtv07pfi3damgjus%40group.calendar.google.com">here</a>.</p>



<a name="175021114"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175021114" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Turon <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175021114">(Sep 05 2019 at 22:35)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116122">@simulacrum</span> <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span></p>



<a name="175021203"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175021203" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175021203">(Sep 05 2019 at 22:37)</a>:</h4>
<p>Would you be interested / feel it beneficial for others to attend as well? I can make that slot.</p>



<a name="175021355"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175021355" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175021355">(Sep 05 2019 at 22:39)</a>:</h4>
<p><span class="user-mention" data-user-id="116010">@Aaron Turon</span> ^</p>



<a name="175021762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175021762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Turon <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175021762">(Sep 05 2019 at 22:46)</a>:</h4>
<p>Ah, yes, sorry that wasn't clear! This was meant as a general invite for anybody who'd like to join, especially if you think you might like to work on the issues that will come out of it</p>



<a name="175022482"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175022482" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175022482">(Sep 05 2019 at 23:00)</a>:</h4>
<p>Okay sounds good, I'll most likely be there then. Thanks for the invite!</p>



<a name="175083161"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175083161" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175083161">(Sep 06 2019 at 17:01)</a>:</h4>
<p>On my way :)</p>



<a name="175083456"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175083456" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Turon <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175083456">(Sep 06 2019 at 17:05)</a>:</h4>
<p><a href="https://paper.dropbox.com/doc/rustc-shared-state-audit--AkP9nsWzaezFriSbMjeLm5iJAg-zsOrKjkMZbBYZJWhgXPke" target="_blank" title="https://paper.dropbox.com/doc/rustc-shared-state-audit--AkP9nsWzaezFriSbMjeLm5iJAg-zsOrKjkMZbBYZJWhgXPke">https://paper.dropbox.com/doc/rustc-shared-state-audit--AkP9nsWzaezFriSbMjeLm5iJAg-zsOrKjkMZbBYZJWhgXPke</a></p>



<a name="175083758"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175083758" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175083758">(Sep 06 2019 at 17:08)</a>:</h4>
<p>ps <span class="user-mention" data-user-id="116266">@Santiago Pastorino</span> this meeting might interest you too, if you're avail <span aria-label="point up" class="emoji emoji-1f446" role="img" title="point up">:point_up:</span>  (happening now)</p>



<a name="175089291"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175089291" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175089291">(Sep 06 2019 at 18:13)</a>:</h4>
<p><span class="user-mention" data-user-id="116010">@Aaron Turon</span> I'd personally be willing to take on work like e.g. the refactor to librustc_error::Handler and such; do we want some sort of document for this? Maybe just opening a bunch of issues on rust-lang/rust and assigning folks is a good idea</p>



<a name="175090004"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175090004" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Aaron Turon <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175090004">(Sep 06 2019 at 18:21)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> that sounds awesome! just drop a note in the shared doc for the time being, and when i open the issue i'll go ahead and assign you <span aria-label="heart" class="emoji emoji-2764" role="img" title="heart">:heart:</span></p>



<a name="175090170"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175090170" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175090170">(Sep 06 2019 at 18:23)</a>:</h4>
<p>done</p>



<a name="175096293"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175096293" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175096293">(Sep 06 2019 at 19:32)</a>:</h4>
<p><a href="https://youtu.be/P1VOMcO7d4c" target="_blank" title="https://youtu.be/P1VOMcO7d4c">Video will go live at this URL</a></p>
<div class="youtube-video message_inline_image"><a data-id="P1VOMcO7d4c" href="https://youtu.be/P1VOMcO7d4c" target="_blank" title="https://youtu.be/P1VOMcO7d4c"><img src="https://i.ytimg.com/vi/P1VOMcO7d4c/default.jpg"></a></div>



<a name="175098775"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175098775" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175098775">(Sep 06 2019 at 20:03)</a>:</h4>
<p>should be live now</p>



<a name="175112684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175112684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Zoxc <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175112684">(Sep 06 2019 at 23:26)</a>:</h4>
<p><code>ty::Steal</code> cannot deadlock btw. The <code>steal</code> operation is bounded and <code>borrow</code> can only block on it.</p>



<a name="175262965"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175262965" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175262965">(Sep 09 2019 at 17:20)</a>:</h4>
<p><span class="user-mention" data-user-id="116466">@Zoxc</span> ah, I guess it's a read/write lock, duh.</p>



<a name="175262974"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/187679-t-compiler/wg-parallel-rustc/topic/review%20meeting%202019-09-06/near/175262974" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/187679-t-compiler/wg-parallel-rustc/topic/review.20meeting.202019-09-06.html#175262974">(Sep 09 2019 at 17:20)</a>:</h4>
<p>in that case, I agree</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>